Hi Mauro, Randy, On Mon, 20 Apr 2020 at 13:45, Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote: > > building it with a random config causes a warning: > > WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0 > Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y]) && OF [=n] > Selected by [y]: > - VIDEO_ROCKCHIP_ISP1 [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && VIDEO_V4L2 [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y]) > > Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> Thanks for the patch. Please note this warning (plus another one), is already fixed by a couple patches in this series: https://patchwork.linuxtv.org/project/linux-media/list/?series=2094 Also, Arnd sent a similar fix recently: https://lkml.org/lkml/2020/4/8/596 The series I posted is acked by Helen and should fix all issues, so perhaps you can merge it before more people keep finding this :-) Thanks, Ezequiel > --- > drivers/staging/media/rkisp1/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig > index 5ecbefa0f5ec..07e4a6e4458e 100644 > --- a/drivers/staging/media/rkisp1/Kconfig > +++ b/drivers/staging/media/rkisp1/Kconfig > @@ -2,7 +2,7 @@ > > config VIDEO_ROCKCHIP_ISP1 > tristate "Rockchip Image Signal Processing v1 Unit driver" > - depends on VIDEO_V4L2 > + depends on VIDEO_V4L2 && OF > depends on ARCH_ROCKCHIP || COMPILE_TEST > select MEDIA_CONTROLLER > select VIDEO_V4L2_SUBDEV_API > -- > 2.25.2 >
