Re: [PATCH] toml: fix misleading identation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/04/2020 23:16, Rosen Penev wrote:
> Found with gcc's -Wmisleading-indentation
> 
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

I've merged this with the '[PATCH] treewide: do not use return after else'
patch.

I'll still mark it as Accepted in patchwork, though.

Regards,

	Hans

> ---
>  utils/common/toml.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/common/toml.c b/utils/common/toml.c
> index dc9868a2..68cebef9 100644
> --- a/utils/common/toml.c
> +++ b/utils/common/toml.c
> @@ -1697,7 +1697,8 @@ int toml_rtots(const char* src_, toml_timestamp_t* ret)
>          for (i = 0; i < 10; i++, p++) {
>              int xx = *p;
>              if (xx == '-') {
> -                if (i == 4 || i == 7) continue; return -1;
> +                if (i == 4 || i == 7) continue;
> +                return -1;
>              }
>              if (! ('0' <= xx && xx <= '9')) return -1;
>              val = val * 10 + (xx - '0');
> @@ -1724,7 +1725,8 @@ int toml_rtots(const char* src_, toml_timestamp_t* ret)
>      for (i = 0; i < 8; i++, p++) {
>          int xx = *p;
>          if (xx == ':') {
> -            if (i == 2 || i == 5) continue; return -1;
> +            if (i == 2 || i == 5) continue;
> +            return -1;
>          }
>          if (! ('0' <= xx && xx <= '9')) return -1;
>          val = val * 10 + (xx - '0');
> 




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux