[bug report] media: cec-gpio: add HDMI CEC GPIO driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Hans Verkuil,

The patch 1e33936d3bae: "media: cec-gpio: add HDMI CEC GPIO driver"
from Jun 28, 2017, leads to the following static checker warning:

	drivers/media/cec/platform/cec-gpio/cec-gpio.c:40 cec_gpio_read()
	warn: signedness bug returning '(-4095)'

drivers/media/cec/platform/cec-gpio/cec-gpio.c
    34  static bool cec_gpio_read(struct cec_adapter *adap)
    35  {
    36          struct cec_gpio *cec = cec_get_drvdata(adap);
    37  
    38          if (cec->cec_is_low)
    39                  return false;
    40          return gpiod_get_value(cec->cec_gpio);
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
negative error codes become "true".

    41  }

regards,
dan carpenter



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux