Em Fri, 17 Apr 2020 09:52:02 +0200
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> escreveu:
> Hi Mauro,
>
> On Fri, Apr 17, 2020 at 9:34 AM Mauro Carvalho Chehab
> <mchehab+huawei@xxxxxxxxxx> wrote:
> > Em Fri, 17 Apr 2020 09:30:51 +0200
> > Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> escreveu:
> > > On Fri, Apr 17, 2020 at 9:08 AM Mauro Carvalho Chehab
> > > <mchehab+huawei@xxxxxxxxxx> wrote:
> > > > While select would be a great idea for most archs, this
> > > > causes a breakage with s390:
> > > >
> > > > "I don't think that's a good idea, as it suddenly enables selecting all PCI
> > > > drivers on platforms that do not have PCI.
> > > >
> > > > WARNING: unmet direct dependencies detected for PCI
> > > > Depends on [n]: HAVE_PCI [=n]
> > > > Selected by [m]:
> > > > - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y])
> > > >
> > > > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> > >
> > > Thanks for your patch!
> > >
> > > Fixes: 4be5e8648b0c287a ("media: move CEC platform drivers to a
> > > separate directory")
> > > Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> >
> > Btw, I almost solved it on a different way, keeping the select and making
> > it depends on HAVE_PCI.
>
> Like you did for the similar change to USB?
Yes.
The thing is: there are several other drivers that already select USB
(and one driver selecting USB_ACM). So, this didn't sound too risky.
On the other hand, there's currently nothing selecting "PCI". So,
in order to avoid more (possible) Kconfig noise, I opted to be
more conservative here.
Thanks,
Mauro
