Devin Heitmueller wrote:
> On Tue, Mar 2, 2010 at 3:28 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> I had some extended discussion with Mauro on this yesterday on
> #linuxtv, and he is now in favor of introducing a standard user
===
> control for chroma gain, as opposed to doing a private control at all.
To be clear: I was never against ;)
It is worthy to summarize the discussions we have and the rationale to
create another control for it.
I've checked the datasheets of some chipsets, and the chroma gain is
different than the saturation control: the gain control (chroma or luma)
are applied at the analog input (or analog input samples) before the color
decoding, while the saturation is applied to the U/V output levels (some
datasheets call it as U/V output gain - causing some mess on the interpretation
of this value).
Also, saa7134 code as already some code to control the chroma gain. The driver
currently just puts some default value there, enabling AGC for PAL/NTSC and
disabling it for SECAM - but - as we have already troubles with AGC with cx88
and saa711x, I don't doubt that we may need to add the control logic there
to solve the same kind of trouble with composite/svideo inputs and some sources
that has a very high gain at the U/V level.
So, this control is not private to saa711x chipsets, but this control is also
present on other devices as well.
The API spec patch should clearly state that Saturation is for the U/V output
level, while gain is for the analog input gain.
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
