Hi, On Tue, Apr 7, 2020 at 11:49 PM Dmitry Sepp <dmitry.sepp@xxxxxxxxxxxxxxx> wrote: > > Hi, > > > +\item[VIRTIO_VIDEO_CMD_STREAM_DESTROY] Destroy a video stream > > + (context) within the device. > > + > > +\begin{lstlisting} > > +struct virtio_video_stream_destroy { > > + struct virtio_video_cmd_hdr hdr; > > +}; > > +\end{lstlisting} > > Let's add more strict description to stream_destroy, like as follows: > Device MUST NOT generate any events for the stream in question after receiving > the command. Before completing the command, Device MUST ensure that all > asynchronous commands that are related to the stream have been completed and > all memory objects are unreferenced. Sounds good. But, the device should probably be able to generate VIRTIO_VIDEO_EVENT_ERROR for a device-wide error? Or, should VIRTIO_VIDEO_EVENT_ERROR always be a per-stream error? (I haven't documented it in v3) Best regards, Keiichi > > Best regards, > Dmitry. > > >