On Wed, 2020-04-08 at 17:52 +0200, Arnd Bergmann wrote: > When compile-testing with CONFIG_OF disabled, we get a warning > about an unused variable, and about inconsistent Kconfig dependencies: > > WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0 > Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=m] && (ARCH_ROCKCHIP [=n] || COMPILE_TEST [=y]) && OF [=n] > Selected by [m]: > - VIDEO_ROCKCHIP_ISP1 [=m] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=m] && VIDEO_V4L2 [=m] && VIDEO_V4L2_SUBDEV_API [=y] && > (ARCH_ROCKCHIP [=n] || COMPILE_TEST [=y]) > > drivers/staging/media/rkisp1/rkisp1-dev.c: In function 'rkisp1_probe': > drivers/staging/media/rkisp1/rkisp1-dev.c:457:22: error: unused variable 'node' [-Werror=unused-variable] > 457 | struct device_node *node = pdev->dev.of_node; > > Simply open-coding the pointer dereference in the only place > the variable is used avoids the warning in all configurations, > so we can allow compile-testing as well. > Hello Arnd, Thanks for your patch. I believe this is already fixed here: https://patchwork.linuxtv.org/patch/62774/ https://patchwork.linuxtv.org/patch/62775/ Cheers, Ezequiel
