Hi Geert, Thank you for the review. On Tue, Apr 7, 2020 at 8:17 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Mon, Apr 6, 2020 at 6:43 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > > Modes in the driver are based on xvclk frequency fixed to 24MHz, but where > > as the OV5645 sensor can support the xvclk frequency ranging from 6MHz to > > 24MHz. So instead making clock-frequency as dt-property just let the > > driver enforce the required clock frequency. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > However, still wondering about the "xvclk" name above and in the definition > below. Is this the naming from the datasheet? > The DT bindings nor the driver use the "xvclk" naming. > xvclk naming is from the datasheet, although the 0v5645 datasheet on publicly available I have referred [1]/[2]. If I am not wrong all the ov sensors have the same naming convention as xvclk. [1] https://cdn.sparkfun.com/datasheets/Sensors/LightImaging/OV5640_datasheet.pdf [2] https://www.ovt.com/download/sensorpdf/126/OmniVision_OV5645.pdf Cheers, --Prabhakar > > --- a/drivers/media/i2c/ov5645.c > > +++ b/drivers/media/i2c/ov5645.c > > @@ -61,6 +61,8 @@ > > #define OV5645_SDE_SAT_U 0x5583 > > #define OV5645_SDE_SAT_V 0x5584 > > > > +#define OV5645_XVCLK_FREQ 24000000 > > + > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
