Hi Sakari, (CC'ing Maxime) On Mon, Apr 06, 2020 at 07:51:08PM +0300, Sakari Ailus wrote: > On Mon, Apr 06, 2020 at 05:42:38PM +0100, Lad Prabhakar wrote: > > Modes in the driver are based on xvclk frequency fixed to 24MHz, but where > > as the OV5645 sensor can support the xvclk frequency ranging from 6MHz to > > 24MHz. So instead making clock-frequency as dt-property just let the > > driver enforce the required clock frequency. > > Even if some current systems where the driver is used are using 24 MHz > clock, that doesn't mean there wouldn't be systems using another frequency > that the driver does not support right now. > > The driver really should not set the frequency unless it gets it from DT, > but I think the preferred means is to use assigned-clock-rates instead, and > not to involve the driver with setting the frequency. > > Otherwise we'll make it impossible to support other frequencies, at least > without more or less random defaults. We're running in circles here. As the driver only supports 24MHz at the moment, the frequency should be set by the driver, as it's a driver limitation. We can then work on supporting additional frequencies, which will require DT to provide a list of supported frequencies for the system, but that can be done on top. -- Regards, Laurent Pinchart
