Hi Karthik,
On 4/6/20 4:30 AM, Karthik Poduval wrote:
> ISP and DPHY device entries missing so add them.>
> tested on tinkerbaord with ov5647 using command
> cam -c 1 -C -F cap
>
> Reported-by: Karthik Poduval <karthik.poduval@xxxxxxxxx>
Please see my previous comment regarding this tag.
> Signed-off-by: Karthik Poduval <karthik.poduval@xxxxxxxxx>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 9beb662166aa..adea8189abd9 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -247,6 +247,23 @@
> ports = <&vopl_out>, <&vopb_out>;
> };
>
> + isp: isp@ff910000 {
> + compatible = "rockchip,rk3288-rkisp1";
> + reg = <0x0 0xff910000 0x0 0x4000>;
> + interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_ISP>, <&cru ACLK_ISP>,
> + <&cru HCLK_ISP>, <&cru PCLK_ISP_IN>,
> + <&cru SCLK_ISP_JPE>;
> + clock-names = "clk_isp", "aclk_isp",
> + "hclk_isp", "pclk_isp_in",
> + "sclk_isp_jpe";
> + assigned-clocks = <&cru SCLK_ISP>, <&cru SCLK_ISP_JPE>;
> + assigned-clock-rates = <400000000>, <400000000>;
These two items are not in the bindings, are they required? Or should we modify the bindings?
> + power-domains = <&power RK3288_PD_VIO>;
> + iommus = <&isp_mmu>;
> + status = "disabled";
> + };
> +
> sdmmc: mmc@ff0c0000 {
> compatible = "rockchip,rk3288-dw-mshc";
> max-frequency = <150000000>;
> @@ -891,6 +908,14 @@
> status = "disabled";
> };
>
> + mipi_phy_rx0: mipi-phy-rx0 {
> + compatible = "rockchip,rk3288-mipi-dphy-rx0";
> + clocks = <&cru SCLK_MIPIDSI_24M>, <&cru PCLK_MIPI_CSI>;
> + clock-names = "dphy-ref", "pclk";
> + #phy-cells = <0>;
> + status = "disabled";
According to the bindings you also need power-domains here.
hmm, now I wonder if it is required or bindings which needs to
be updated (to be verified).
Also, I would separate this in two patches.
fyi, I'm moving bindings out of staging https://patchwork.linuxtv.org/project/linux-media/list/?series=2103
Thanks,
Helen
> + };
> +
> io_domains: io-domains {
> compatible = "rockchip,rk3288-io-voltage-domain";
> status = "disabled";
>
