Hi Steve,
Thank you for the patch.
On Sat, Apr 04, 2020 at 03:41:30PM -0700, Steve Longerbeam wrote:
> The imx_media_ipu_image_to_mbus_fmt() function doesn't need to modify its
> ipu_image argument. Make it const.
You could squash this with patch 10/11. In any case,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Steve Longerbeam <slongerbeam@xxxxxxxxx>
> ---
> drivers/staging/media/imx/imx-media-utils.c | 2 +-
> drivers/staging/media/imx/imx-media.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
> index b8ee005e4445..c00f253976f5 100644
> --- a/drivers/staging/media/imx/imx-media-utils.c
> +++ b/drivers/staging/media/imx/imx-media-utils.c
> @@ -580,7 +580,7 @@ int imx_media_mbus_fmt_to_ipu_image(struct ipu_image *image,
> EXPORT_SYMBOL_GPL(imx_media_mbus_fmt_to_ipu_image);
>
> int imx_media_ipu_image_to_mbus_fmt(struct v4l2_mbus_framefmt *mbus,
> - struct ipu_image *image)
> + const struct ipu_image *image)
> {
> const struct imx_media_pixfmt *fmt;
>
> diff --git a/drivers/staging/media/imx/imx-media.h b/drivers/staging/media/imx/imx-media.h
> index c03114a6f6c8..af806ecc67a9 100644
> --- a/drivers/staging/media/imx/imx-media.h
> +++ b/drivers/staging/media/imx/imx-media.h
> @@ -189,7 +189,7 @@ int imx_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
> int imx_media_mbus_fmt_to_ipu_image(struct ipu_image *image,
> const struct v4l2_mbus_framefmt *mbus);
> int imx_media_ipu_image_to_mbus_fmt(struct v4l2_mbus_framefmt *mbus,
> - struct ipu_image *image);
> + const struct ipu_image *image);
> void imx_media_grp_id_to_sd_name(char *sd_name, int sz,
> u32 grp_id, int ipu_id);
> struct v4l2_subdev *
--
Regards,
Laurent Pinchart
