Hi Helen, > From: Helen Koike <helen.koike@xxxxxxxxxxxxx> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 33cc21fcf4c10..fc0295d2a65a1 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1394,6 +1394,17 @@ io_domains: io-domains { > status = "disabled"; > }; > > + mipi_dphy_rx0: mipi-dphy-rx0 { For Heiko sort syscon@ff770000 subnodes alphabetical or reg value first? > + compatible = "rockchip,rk3399-mipi-dphy-rx0"; > + clocks = <&cru SCLK_MIPIDPHY_REF>, > + <&cru SCLK_DPHY_RX0_CFG>, > + <&cru PCLK_VIO_GRF>; Align ^ > + clock-names = "dphy-ref", "dphy-cfg", "grf"; > + power-domains = <&power RK3399_PD_VIO>; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > u2phy0: usb2-phy@e450 { > compatible = "rockchip,rk3399-usb2phy"; > reg = <0xe450 0x10>; > -- > 2.26.0