On Sun, 28 Feb 2010 19:38:14 +0100 Jean-Francois Moine <moinejf@xxxxxxx> wrote: > On Sat, 27 Feb 2010 21:20:22 +0100 > Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote: > > > Exposure is now a u16 value, both MSB and LSB are set, but values in > > the v4l2 control are limited to the interval [0,506] as 0x01fa (506) > > is the maximum observed value with AEC enabled. > [snip] > > .type = V4L2_CTRL_TYPE_INTEGER, > > .name = "Exposure", > > .minimum = 0, > > - .maximum = 255, > > + .maximum = 506, > > .step = 1, > > #define EXPO_DEF 120 > > .default_value = EXPO_DEF, > > Hi Antonio, > > Do we need a so high precision for the exposure? Just setting the > maximum value to 253 should solve the problem. > JF, the intent here is to cover all the range of values available in Auto Exposure mode too, doesn't this make sense to you? I could set .maximum to 253 to limit the "UI" control precision but then I should use 2*value when setting the registers in order to cover the actual max value, this looks a little unclean. Anyhow, let me know what you prefer, I have no strong feelings on that. If you want to save a byte, I'll agree. Regards, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
Attachment:
pgp7VFOZxDLSU.pgp
Description: PGP signature