Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on sunxi/sunxi/for-next linus/master v5.6 next-20200331] [cannot apply to linux/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Media-Kconfig-menu-reorg-and-improvements/20200401-014843 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-d002-20200331 (attached as .config) compiler: gcc-7 (Debian 7.4.0-6) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): ld: drivers/media/dvb-core/dvbdev.o: in function `dvb_module_probe': >> drivers/media/dvb-core/dvbdev.c:986: undefined reference to `i2c_new_client_device' >> ld: drivers/media/dvb-core/dvbdev.c:993: undefined reference to `i2c_unregister_device' ld: drivers/media/dvb-core/dvbdev.o: in function `dvb_module_release': >> drivers/media/dvb-core/dvbdev.c:1008: undefined reference to `i2c_unregister_device' vim +986 drivers/media/dvb-core/dvbdev.c ^1da177e4c3f41 drivers/media/dvb/dvb-core/dvbdev.c Linus Torvalds 2005-04-16 963 1980bfa67f19d6 drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-07 964 #if IS_ENABLED(CONFIG_I2C) 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 965 struct i2c_client *dvb_module_probe(const char *module_name, 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 966 const char *name, 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 967 struct i2c_adapter *adap, 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 968 unsigned char addr, 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 969 void *platform_data) 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 970 { 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 971 struct i2c_client *client; 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 972 struct i2c_board_info *board_info; 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 973 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 974 board_info = kzalloc(sizeof(*board_info), GFP_KERNEL); 39adb4e739050d drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-22 975 if (!board_info) 39adb4e739050d drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-22 976 return NULL; 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 977 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 978 if (name) c0decac19da390 drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-09-10 979 strscpy(board_info->type, name, I2C_NAME_SIZE); 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 980 else c0decac19da390 drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-09-10 981 strscpy(board_info->type, module_name, I2C_NAME_SIZE); 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 982 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 983 board_info->addr = addr; 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 984 board_info->platform_data = platform_data; 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 985 request_module(module_name); d928440cf4603b drivers/media/dvb-core/dvbdev.c Wolfram Sang 2019-12-16 @986 client = i2c_new_client_device(adap, board_info); d928440cf4603b drivers/media/dvb-core/dvbdev.c Wolfram Sang 2019-12-16 987 if (!i2c_client_has_driver(client)) { 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 988 kfree(board_info); 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 989 return NULL; 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 990 } 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 991 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 992 if (!try_module_get(client->dev.driver->owner)) { 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 @993 i2c_unregister_device(client); 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 994 client = NULL; 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 995 } 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 996 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 997 kfree(board_info); 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 998 return client; 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 999 } 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1000 EXPORT_SYMBOL_GPL(dvb_module_probe); 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1001 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1002 void dvb_module_release(struct i2c_client *client) 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1003 { 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1004 if (!client) 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1005 return; 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1006 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1007 module_put(client->dev.driver->owner); 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 @1008 i2c_unregister_device(client); 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1009 } 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1010 EXPORT_SYMBOL_GPL(dvb_module_release); 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1011 #endif 8f569c0b4e6b6b drivers/media/dvb-core/dvbdev.c Mauro Carvalho Chehab 2018-03-02 1012 :::::: The code at line 986 was first introduced by commit :::::: d928440cf4603b4889af3e6785d9200a626ae0ce media: dvb-core: dvbdev: convert to use i2c_new_client_device() :::::: TO: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> :::::: CC: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
