On 3/30/20 2:10 PM, Hans Verkuil wrote: > On 3/28/20 8:52 AM, Dafna Hirschfeld wrote: >> Since each vimc entity type is defined by the >> callbacks implementation, it is a good idea to >> add a struct to hold these callbacks. >> >> Each vimc entity then declare its type in the file for >> the entity. >> >> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> > > I get these warnings: > > drivers/media/platform/vimc/vimc-capture.c:328:6: warning: no previous prototype for ‘vimc_cap_release’ [-Wmissing-prototypes] > > 328 | void vimc_cap_release(struct vimc_ent_device *ved) > | ^~~~~~~~~~~~~~~~ > drivers/media/platform/vimc/vimc-capture.c:337:6: warning: no previous prototype for ‘vimc_cap_unregister’ [-Wmissing-prototypes] > > 337 | void vimc_cap_unregister(struct vimc_ent_device *ved) > | ^~~~~~~~~~~~~~~~~~~ > drivers/media/platform/vimc/vimc-capture.c:385:25: warning: no previous prototype for ‘vimc_cap_add’ [-Wmissing-prototypes] > > 385 | struct vimc_ent_device *vimc_cap_add(struct vimc_device *vimc, > | ^~~~~~~~~~~~ > CC drivers/media/platform/vimc/vimc-scaler.o > drivers/media/platform/vimc/vimc-debayer.c:497:6: warning: no previous prototype for ‘vimc_deb_release’ [-Wmissing-prototypes] > > 497 | void vimc_deb_release(struct vimc_ent_device *ved) > | ^~~~~~~~~~~~~~~~ > drivers/media/platform/vimc/vimc-debayer.c:525:25: warning: no previous prototype for ‘vimc_deb_add’ [-Wmissing-prototypes] > > 525 | struct vimc_ent_device *vimc_deb_add(struct vimc_device *vimc, > | ^~~~~~~~~~~~ > CC drivers/media/platform/vimc/vimc-sensor.o > drivers/media/platform/vimc/vimc-scaler.c:467:6: warning: no previous prototype for ‘vimc_sca_release’ [-Wmissing-prototypes] > > 467 | void vimc_sca_release(struct vimc_ent_device *ved) > | ^~~~~~~~~~~~~~~~ > drivers/media/platform/vimc/vimc-scaler.c:476:25: warning: no previous prototype for ‘vimc_sca_add’ [-Wmissing-prototypes] > > 476 | struct vimc_ent_device *vimc_sca_add(struct vimc_device *vimc, > | ^~~~~~~~~~~~ > drivers/media/platform/vimc/vimc-sensor.c:282:6: warning: no previous prototype for ‘vimc_sen_release’ [-Wmissing-prototypes] > > 282 | void vimc_sen_release(struct vimc_ent_device *ved) > | ^~~~~~~~~~~~~~~~ > drivers/media/platform/vimc/vimc-sensor.c:310:25: warning: no previous prototype for ‘vimc_sen_add’ [-Wmissing-prototypes] > > 310 | struct vimc_ent_device *vimc_sen_add(struct vimc_device *vimc, > | ^~~~~~~~~~~~ > > > I think that all these functions should become static. Forgot to mention: the other patches in this series look fine, so I'll take those and wait for a v2 of this last patch. Regards, Hans
