There are 4 pads between the entities
rkisp1_isp, rkisp1_params, rkisp1_stats that transmit
metadata. Since metadata has no dimensions, it makes
sense to set the width and height of these pads to 0.
The problem is that it makes the v4l-compliance tests fail.
Currently, in order to silent the tests, the width
and height are set to RKISP1_DEFAULT_*
This patchset sets the dimensions to 0 and solves the
compliance error by introducing a new flag
MEDIA_PAD_FL_METADATA in media.h and setting
this flag to those pads.
Then the v4l2-compliance tests can skip the
dimensions test if this flag is set.
This is just a suggested implementation from Laurent,
a better documentation is probably needed.
Another possible solution suggested by Verkuil
is to add a new media bus format: MEDIA_BUS_FMT_FIXED_METADATA.
- patch 1: introduces the the flag
- patch 2: set the flag to the pads and removes a related TODO item
A corresponding patch to v4l-utils will be sent.
Dafna Hirschfeld (2):
media: media.h: Add a pad flag MEDIA_PAD_FL_METADATA
media: staging: rkisp1: add the flag MEDIA_PAD_FL_METADATA to the
metadata pads
Documentation/media/uapi/mediactl/media-types.rst | 4 ++++
drivers/staging/media/rkisp1/TODO | 1 -
drivers/staging/media/rkisp1/rkisp1-isp.c | 10 ++++++----
drivers/staging/media/rkisp1/rkisp1-params.c | 2 +-
drivers/staging/media/rkisp1/rkisp1-stats.c | 2 +-
include/uapi/linux/media.h | 1 +
6 files changed, 13 insertions(+), 7 deletions(-)
--
2.17.1
