On 3/25/20 12:03 PM, Sakari Ailus wrote: > Hi Sowjanya, > > Thanks for the patchset. > > On Mon, Mar 23, 2020 at 10:52:32AM -0700, Sowjanya Komatineni wrote: >> Tegra210 contains a powerful Video Input (VI) hardware controller >> which can support up to 6 MIPI CSI camera sensors. >> >> Each Tegra CSI port can be one-to-one mapped to VI channel and can >> capture from an external camera sensor connected to CSI or from >> built-in test pattern generator. >> >> Tegra210 supports built-in test pattern generator from CSI to VI. >> >> This patch adds a V4L2 media controller and capture driver support >> for Tegra210 built-in CSI to VI test pattern generator. >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx> >> --- >> drivers/staging/media/Kconfig | 2 + >> drivers/staging/media/Makefile | 1 + >> drivers/staging/media/tegra/Kconfig | 10 + >> drivers/staging/media/tegra/Makefile | 8 + >> drivers/staging/media/tegra/TODO | 10 + >> drivers/staging/media/tegra/tegra-common.h | 263 +++++++ >> drivers/staging/media/tegra/tegra-csi.c | 522 ++++++++++++++ >> drivers/staging/media/tegra/tegra-csi.h | 118 ++++ >> drivers/staging/media/tegra/tegra-vi.c | 1058 ++++++++++++++++++++++++++++ >> drivers/staging/media/tegra/tegra-vi.h | 83 +++ >> drivers/staging/media/tegra/tegra-video.c | 129 ++++ >> drivers/staging/media/tegra/tegra-video.h | 32 + >> drivers/staging/media/tegra/tegra210.c | 754 ++++++++++++++++++++ >> drivers/staging/media/tegra/tegra210.h | 192 +++++ > > Why staging? Are there reasons not to aim this to the kernel proper right > away? If you only support TPG, the driver may not have too many (if any) > real users anyway. A TPG-only driver is not very useful, and I do not believe that belongs in the kernel proper. The next phase will add sensor support, and that's a good time to move it in the kernel itself. Regards, Hans
