Hi Mauro, On Wed, Mar 25, 2020 at 10:49:29AM +0100, Mauro Carvalho Chehab wrote: > Let's place the main API selections at the media/Kconfig file, > as this way we can better organize things. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > --- > drivers/media/Kconfig | 9 +++++++++ > drivers/media/mc/Kconfig | 9 --------- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig > index d6766085c91b..3872e46545e6 100644 > --- a/drivers/media/Kconfig > +++ b/drivers/media/Kconfig > @@ -144,6 +144,15 @@ config VIDEO_DEV > depends on MEDIA_SUPPORT > default MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT || MEDIA_PLATFORM_SUPPORT > > +config MEDIA_CONTROLLER > + bool "Media Controller API" > + depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT > + help > + Enable the media controller API used to query media devices internal > + topology and configure it dynamically. > + > + This API is mostly used by camera interfaces in embedded platforms. > + > source "drivers/media/v4l2-core/Kconfig" > > # > diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig > index 3b9795cfcb36..b3579d6c9e32 100644 > --- a/drivers/media/mc/Kconfig > +++ b/drivers/media/mc/Kconfig > @@ -3,15 +3,6 @@ > # Selectable only for webcam/grabbers, as other drivers don't use it > # > > -config MEDIA_CONTROLLER > - bool "Media Controller API" > - depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT > - help > - Enable the media controller API used to query media devices internal > - topology and configure it dynamically. > - > - This API is mostly used by camera interfaces in embedded platforms. > - > config MEDIA_CONTROLLER_DVB > bool "Enable Media controller for DVB (EXPERIMENTAL)" > depends on MEDIA_CONTROLLER && DVB_CORE This moves the main MC configuration out of the directory but leaves the rest of the MC configuration under the mc directory. All MC related configuration is currently in a single place, which makes sense. I guess you can always have arguments for and against, but my preference is keeping it as-is. -- Kind regards, Sakari Ailus
