Re: [PATCH v2 02/20] media: Kconfig: not all V4L2 platform drivers are for camera

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A few more comments...

On Tue, 24 Mar 2020 at 11:26, Mauro Carvalho Chehab
<mchehab+huawei@xxxxxxxxxx> wrote:
>
> When the platform drivers got added, they were all part of
> complex camera support. This is not the case anymore, as we
> now have codecs and other stuff there too.
>
> So, fix the dependencies, in order to not require users to
> manually select something that it doesn't make sense.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> ---
>  drivers/media/Kconfig          | 3 +--
>  drivers/media/platform/Kconfig | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
[..]
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index e01bbb9dd1c1..34f40c2c8c45 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -5,7 +5,6 @@
>
>  menuconfig V4L_PLATFORM_DRIVERS
>         bool "V4L platform devices"

It would be more consistent to have "V4L platform drivers".
Same applies on other _DRIVER menus with "devices" descriptions.

> -       depends on MEDIA_CAMERA_SUPPORT

Also, this same change is needed on V4L_MEM2MEM_DRIVERS.

Thanks,
Ezequiel



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux