Hi Jacopo, Thank you for the patch. On Tue, Mar 24, 2020 at 09:28:44PM +0100, Jacopo Mondi wrote: > Cosmetic change only. > > Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx> > --- > drivers/media/platform/bcm2835/bcm2835-unicam.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c b/drivers/media/platform/bcm2835/bcm2835-unicam.c > index 5001976dcebc..65534a18d3d4 100644 > --- a/drivers/media/platform/bcm2835/bcm2835-unicam.c > +++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c > @@ -2462,7 +2462,7 @@ static int unicam_set_ctrl(struct v4l2_ctrl *ctrl) > /* Change the number of frames of delay we believe there > * to be between updating analogue gain and it taking effect. > */ > - return unicam_update_delay(unicam, > + return unicam_update_delay(unicam, > V4L2_CID_ANALOGUE_GAIN, ctrl->val); While at it, write it return unicam_update_delay(unicam, V4L2_CID_ANALOGUE_GAIN, ctrl->val); Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > default: -- Regards, Laurent Pinchart