Hi Morimoto-san, Kuninori Morimoto, Mon, Mar 23, 2020 01:12:00 +0100: > > As all known variants of the Salvator board have the HDMI decoder > > chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482 > > endpoint and the connection definitions are placed in the common board > > file. > > For the same reason, the CLK_C clock line and I2C configuration (similar > > to the ak4613, on the same interface) are added into the common file. > > > > Signed-off-by: Alexander Riesen <alexander.riesen@xxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > (snip) > > @@ -758,8 +769,19 @@ &rcar_sound { > > <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, > > <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, > > <&audio_clk_a>, <&cs2000>, > > - <&audio_clk_c>, > > + <&adv7482_hdmi_in>, > > <&cpg CPG_CORE CPG_AUDIO_CLK_I>; > > + clock-names = "ssi-all", > > + "ssi.9", "ssi.8", "ssi.7", "ssi.6", > > + "ssi.5", "ssi.4", "ssi.3", "ssi.2", > > + "ssi.1", "ssi.0", > > + "src.9", "src.8", "src.7", "src.6", > > + "src.5", "src.4", "src.3", "src.2", > > + "src.1", "src.0", > > + "mix.1", "mix.0", > > + "ctu.1", "ctu.0", > > + "dvc.0", "dvc.1", > > + "clk_a", "clk_b", "clk_c", "clk_i"; > > I think you don't need to overwrite clock-names here in this case ? I vaguely remember something using the names and failing to enable clk_c without the list spelled out... I shall re-test though, perhaps it was my own code (since removed) using it. Regards, Alex