Hi Laurent, Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100: > On Thu, Mar 19, 2020 at 06:42:36PM +0100, Alex Riesen wrote: > > As the driver has some support for the audio interface of the device, > > the bindings file should mention it. > > While at it, how about converting the bindings to YAML ? :-) It can of > course be done on top. Of course. I shall take a look at that. > > The ADV7481 and ADV7482 are multi format video decoders with an integrated > > HDMI receiver. They can output CSI-2 on two independent outputs TXA and TXB > > -from three input sources HDMI, analog and TTL. > > +from three input sources HDMI, analog and TTL. There is also support for an > > +I2S compatible interface connected to the audio processor of the HDMI decoder. > > s/I2S compatible/I2S-compatible/ ? Done. > > +The interface has TDM capability (8 slots, 32 bits, left or right justified). > > > > Required Properties: > > > > @@ -16,6 +18,8 @@ Required Properties: > > slave device on the I2C bus. The main address is mandatory, others are > > optional and remain at default values if not specified. > > > > + - #clock-cells: must be <0> if the I2S port is used > > Wouldn't it be simpler to set it to 0 unconditionally ? Would it? If the port itself is optional, shouldn't the clock be an option too? > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Thanks! Regards, Alex
