Tomi, Thanks for the patch. On 3/19/20 2:50 AM, Tomi Valkeinen wrote: > After ComplexIO reset, a dummy read to PHY is needed as per CAL spec to > finish the reset. Currently the driver reads a ComplexIO register, not > PHY register. Fix this. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Tested-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Nice catch. Reviewed-by: Benoit Parrot <bparrot@xxxxxx> > --- > drivers/media/platform/ti-vpe/cal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c > index ed32b199aabe..e6f766ba3079 100644 > --- a/drivers/media/platform/ti-vpe/cal.c > +++ b/drivers/media/platform/ti-vpe/cal.c > @@ -796,8 +796,8 @@ static void csi2_phy_init(struct cal_ctx *ctx) > ctx->csi2_port, > reg_read(ctx->dev, CAL_CSI2_COMPLEXIO_CFG(ctx->csi2_port))); > > - /* Dummy read to allow SCP to complete */ > - val = reg_read(ctx->dev, CAL_CSI2_COMPLEXIO_CFG(ctx->csi2_port)); > + /* Dummy read to allow SCP reset to complete */ > + reg_read(ctx->cc, CAL_CSI2_PHY_REG0); > > /* 3.A. Program Phy Timing Parameters */ > csi2_phy_config(ctx); >
