Hi Randy, Thanks for catching the bug ! On Fri, Feb 26, 2010 at 2:57 AM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote: > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > Fix precedence so that data is used correctly. > Fixes sparse warning: > drivers/media/dvb/frontends/tda665x.c:136:55: warning: right shift by bigger than source value > > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > Cc: Manu Abraham <abraham.manu@xxxxxxxxx> Reviewed-by: Manu Abraham <manu@xxxxxxxxxxx> Acked-by: Manu Abraham <manu@xxxxxxxxxxx> > --- > drivers/media/dvb/frontends/tda665x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- lnx-2633-spr.orig/drivers/media/dvb/frontends/tda665x.c > +++ lnx-2633-spr/drivers/media/dvb/frontends/tda665x.c > @@ -133,7 +133,7 @@ static int tda665x_set_state(struct dvb_ > frequency += config->ref_divider >> 1; > frequency /= config->ref_divider; > > - buf[0] = (u8) (frequency & 0x7f00) >> 8; > + buf[0] = (u8) ((frequency & 0x7f00) >> 8); > buf[1] = (u8) (frequency & 0x00ff) >> 0; > buf[2] = 0x80 | 0x40 | 0x02; > buf[3] = 0x00; > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
