Re: [PATCH] media: doc-rst: in the RGB formats table add '-' in undefined bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dafna,

Thank you for the patch.

On Mon, Mar 16, 2020 at 05:31:25PM +0100, Dafna Hirschfeld wrote:
> hi, adding suggested-by
> 
> On 16.03.20 16:56, Dafna Hirschfeld wrote:
> > In the table of the RGB formats, add an explicit '-' signs
> > to cells that contain undefined bits.
> > This makes it more clear how many bits and bytes are used
> > for each format.
> > 
> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
>
> Suggested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> > ---
> >   Documentation/media/uapi/v4l/pixfmt-rgb.rst | 136 ++++++++++----------
> >   1 file changed, 68 insertions(+), 68 deletions(-)
> > 
> > diff --git a/Documentation/media/uapi/v4l/pixfmt-rgb.rst b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> > index 4ce305cc45da..e4adac7f2e4c 100644
> > --- a/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> > +++ b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> > @@ -128,10 +128,10 @@ next to each other in memory.
> >         - b\ :sub:`1`
> >         - b\ :sub:`0`
> >   
> > -      -
> > -      -
> > -      -
> > -      -
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> >         - r\ :sub:`3`
> >         - r\ :sub:`2`
> >         - r\ :sub:`1`
> > @@ -169,10 +169,10 @@ next to each other in memory.
> >         - b\ :sub:`2`
> >         - b\ :sub:`1`
> >         - b\ :sub:`0`
> > -      -
> > -      -
> > -      -
> > -      -
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> >   
> >         - r\ :sub:`3`
> >         - r\ :sub:`2`
> > @@ -220,10 +220,10 @@ next to each other in memory.
> >         - r\ :sub:`1`
> >         - r\ :sub:`0`
> >   
> > -      -
> > -      -
> > -      -
> > -      -
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> >         - b\ :sub:`3`
> >         - b\ :sub:`2`
> >         - b\ :sub:`1`
> > @@ -261,10 +261,10 @@ next to each other in memory.
> >         - r\ :sub:`2`
> >         - r\ :sub:`1`
> >         - r\ :sub:`0`
> > -      -
> > -      -
> > -      -
> > -      -
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> >   
> >         - b\ :sub:`3`
> >         - b\ :sub:`2`
> > @@ -312,7 +312,7 @@ next to each other in memory.
> >         - b\ :sub:`1`
> >         - b\ :sub:`0`
> >   
> > -      -
> > +      - `-`
> >         - r\ :sub:`4`
> >         - r\ :sub:`3`
> >         - r\ :sub:`2`
> > @@ -356,7 +356,7 @@ next to each other in memory.
> >         - b\ :sub:`2`
> >         - b\ :sub:`1`
> >         - b\ :sub:`0`
> > -      -
> > +      - `-`
> >   
> >         - r\ :sub:`4`
> >         - r\ :sub:`3`
> > @@ -404,7 +404,7 @@ next to each other in memory.
> >         - r\ :sub:`1`
> >         - r\ :sub:`0`
> >   
> > -      -
> > +      - `-`
> >         - b\ :sub:`4`
> >         - b\ :sub:`3`
> >         - b\ :sub:`2`
> > @@ -448,7 +448,7 @@ next to each other in memory.
> >         - r\ :sub:`2`
> >         - r\ :sub:`1`
> >         - r\ :sub:`0`
> > -      -
> > +      - `-`
> >   
> >         - b\ :sub:`4`
> >         - b\ :sub:`3`
> > @@ -510,7 +510,7 @@ next to each other in memory.
> >         - ``V4L2_PIX_FMT_XRGB555X``
> >         - 'XR15' | (1 << 31)
> >   
> > -      -
> > +      - `-`
> >         - r\ :sub:`4`
> >         - r\ :sub:`3`
> >         - r\ :sub:`2`
> > @@ -640,21 +640,21 @@ next to each other in memory.
> >   
> >         - r\ :sub:`1`
> >         - r\ :sub:`0`
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> >       * .. _V4L2-PIX-FMT-ABGR32:
> >   
> >         - ``V4L2_PIX_FMT_ABGR32``
> > @@ -727,14 +727,14 @@ next to each other in memory.
> >         - r\ :sub:`1`
> >         - r\ :sub:`0`
> >   
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> >       * .. _V4L2-PIX-FMT-BGRA32:
> >   
> >         - ``V4L2_PIX_FMT_BGRA32``
> > @@ -780,14 +780,14 @@ next to each other in memory.
> >         - ``V4L2_PIX_FMT_BGRX32``
> >         - 'RX24'
> >   
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> >   
> >         - b\ :sub:`7`
> >         - b\ :sub:`6`
> > @@ -887,14 +887,14 @@ next to each other in memory.
> >         - b\ :sub:`1`
> >         - b\ :sub:`0`
> >   
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> >       * .. _V4L2-PIX-FMT-ARGB32:
> >   
> >         - ``V4L2_PIX_FMT_ARGB32``
> > @@ -940,14 +940,14 @@ next to each other in memory.
> >         - ``V4L2_PIX_FMT_XRGB32``
> >         - 'BX24'
> >   
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > -      -
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> > +      - `-`
> >   
> >         - r\ :sub:`7`
> >         - r\ :sub:`6`
> > 

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux