On 16/03/2020 12:51, Hans Verkuil wrote:
On 3/16/20 11:06 AM, Hans Verkuil wrote:
Hi Tomi,
On 3/13/20 12:41 PM, Tomi Valkeinen wrote:
CAL reports various errors via IRQs, which are not handled at all by the
current driver. Add code to enable and catch those IRQs and print
errors. This will make it much easier to notice and debug issues with
sensors.
Can you rebase your series to the media_tree master branch? Other recently
merged patches from Benoit now conflict with at least this patch.
I reviewed this series and it looks good otherwise (just one other small comment
about a confusing log message), so once I have a rebased version I can make
a PR for it.
Just to confirm: this series has been tested with a real sensor, right? If so,
please add a Tested-by line as well.
Yes, I'm using OV5640.
I thought tested-by by the author is implicit, unless otherwise clearly noted. But if it's the
custom with linux-media, I can add those.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
