Re: [v2] dma-buf: heaps: bugfix for selftest failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/7/20 7:02 AM, Leon He wrote:
From: Leon He <leon.he@xxxxxxxxxx>

There are two errors in the dmabuf-heap selftest:
1. The 'char name[5]' was not initialized to zero, which will cause
    strcmp(name, "vgem") failed in check_vgem().
2. The return value of test_alloc_errors() should be reversed, other-
    wise the while loop in main() will be broken.

Signed-off-by: Leon He <leon.he@xxxxxxxxxx>
---
  tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
index cd5e1f6..836b185 100644
--- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
+++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
@@ -22,7 +22,7 @@
  static int check_vgem(int fd)
  {
  	drm_version_t version = { 0 };
-	char name[5];
+	char name[5] = { 0 };
  	int ret;
version.name_len = 4;

Please see my comment on v1 for this.

@@ -357,7 +357,7 @@ static int test_alloc_errors(char *heap_name)
  	if (heap_fd >= 0)
  		close(heap_fd);
- return ret;
+	return !ret;

This change doesn't make sense. Initializing ret to 0 is a better
way to go.

thanks,
-- Shuah



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux