On 3/12/20 11:15 AM, Dmitry Sepp wrote: > Hi Hans, > > Thank you for your great detailed review! > > I won't provide inline answers as your comments totally make sense. There is > only one thing I want to mention: > >>> + struct video_plane_format plane_format[VIRTIO_VIDEO_MAX_PLANES]; >> >> Why is this virtio specific? Any reason for not using VIDEO_MAX_PLANES? > > I'd say this is because VIDEO_MAX_PLANES does not exist outside of the Linux > OS, so for whatever other system we need a virtio specific definition. OK, good reason :-) It's probably a good thing to add a comment where VIRTIO_VIDEO_MAX_PLANES is defined that explains this. Regards, Hans
