Hi Ezequiel, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v5.6-rc5 next-20200311] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Ezequiel-Garcia/hantro-set-of-small-cleanups-and-fixes/20200312-061234 base: git://linuxtv.org/media_tree.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=sh If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/staging/media/hantro/hantro_v4l2.c: In function 'hantro_try_fmt': >> drivers/staging/media/hantro/hantro_v4l2.c:282:30: warning: passing argument 1 of 'hantro_needs_postproc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 282 | !hantro_needs_postproc(ctx, fmt)) | ^~~ In file included from drivers/staging/media/hantro/hantro_v4l2.c:29: drivers/staging/media/hantro/hantro.h:420:42: note: expected 'struct hantro_ctx *' but argument is of type 'const struct hantro_ctx *' 420 | hantro_needs_postproc(struct hantro_ctx *ctx, const struct hantro_fmt *fmt) | ~~~~~~~~~~~~~~~~~~~^~~ vim +282 drivers/staging/media/hantro/hantro_v4l2.c 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 234 0f07bff2f08018 drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2020-03-11 235 static int hantro_try_fmt(const struct hantro_ctx *ctx, 0f07bff2f08018 drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2020-03-11 236 struct v4l2_pix_format_mplane *pix_mp, 0f07bff2f08018 drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2020-03-11 237 enum v4l2_buf_type type) 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 238 { 5980d40276b36b drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2019-12-05 239 const struct hantro_fmt *fmt, *vpu_fmt; 0f07bff2f08018 drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2020-03-11 240 bool capture = !V4L2_TYPE_IS_OUTPUT(type); 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 241 bool coded; 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 242 a29add8c9bb29d drivers/staging/media/hantro/hantro_v4l2.c Philipp Zabel 2019-06-12 243 coded = capture == hantro_is_encoder_ctx(ctx); 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 244 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 245 vpu_debug(4, "trying format %c%c%c%c\n", 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 246 (pix_mp->pixelformat & 0x7f), 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 247 (pix_mp->pixelformat >> 8) & 0x7f, 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 248 (pix_mp->pixelformat >> 16) & 0x7f, 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 249 (pix_mp->pixelformat >> 24) & 0x7f); 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 250 5980d40276b36b drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2019-12-05 251 fmt = hantro_find_format(ctx, pix_mp->pixelformat); 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 252 if (!fmt) { 5980d40276b36b drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2019-12-05 253 fmt = hantro_get_default_fmt(ctx, coded); 0f07bff2f08018 drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2020-03-11 254 pix_mp->pixelformat = fmt->fourcc; 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 255 } 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 256 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 257 if (coded) { 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 258 pix_mp->num_planes = 1; 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 259 vpu_fmt = fmt; a29add8c9bb29d drivers/staging/media/hantro/hantro_v4l2.c Philipp Zabel 2019-06-12 260 } else if (hantro_is_encoder_ctx(ctx)) { 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 261 vpu_fmt = ctx->vpu_dst_fmt; 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 262 } else { 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 263 vpu_fmt = ctx->vpu_src_fmt; 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 264 /* 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 265 * Width/height on the CAPTURE end of a decoder are ignored and 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 266 * replaced by the OUTPUT ones. 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 267 */ 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 268 pix_mp->width = ctx->src_fmt.width; 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 269 pix_mp->height = ctx->src_fmt.height; 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 270 } 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 271 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 272 pix_mp->field = V4L2_FIELD_NONE; 0a4f091c12b3ea drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Boris Brezillon 2019-05-28 273 0a4f091c12b3ea drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Boris Brezillon 2019-05-28 274 v4l2_apply_frmsize_constraints(&pix_mp->width, &pix_mp->height, 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 275 &vpu_fmt->frmsize); 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 276 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 277 if (!coded) { 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 278 /* Fill remaining fields */ 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 279 v4l2_fill_pixfmt_mp(pix_mp, fmt->fourcc, pix_mp->width, 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 280 pix_mp->height); 8c2d66b036c778 drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2019-12-05 281 if (ctx->vpu_src_fmt->fourcc == V4L2_PIX_FMT_H264_SLICE && 042584e9055b61 drivers/staging/media/hantro/hantro_v4l2.c Philipp Zabel 2020-01-27 @282 !hantro_needs_postproc(ctx, fmt)) a9471e25629b02 drivers/staging/media/hantro/hantro_v4l2.c Hertz Wong 2019-08-16 283 pix_mp->plane_fmt[0].sizeimage += 6574b7394c10e2 drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2020-03-11 284 hantro_h264_mv_size(pix_mp->width, 6574b7394c10e2 drivers/staging/media/hantro/hantro_v4l2.c Ezequiel Garcia 2020-03-11 285 pix_mp->height); 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 286 } else if (!pix_mp->plane_fmt[0].sizeimage) { 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 287 /* 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 288 * For coded formats the application can specify 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 289 * sizeimage. If the application passes a zero sizeimage, 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 290 * let's default to the maximum frame size. 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 291 */ 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 292 pix_mp->plane_fmt[0].sizeimage = fmt->header_size + 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 293 pix_mp->width * pix_mp->height * fmt->max_depth; 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 294 } 953aaa1492c538 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c Boris Brezillon 2019-05-28 295 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 296 return 0; 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 297 } 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c Ezequiel Garcia 2018-12-05 298 :::::: The code at line 282 was first introduced by commit :::::: 042584e9055b615ac917239884fb0d65690f56ec media: hantro: fix extra MV/MC sync space calculation :::::: TO: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> :::::: CC: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
