Hi Steve, On Wed, Mar 11, 2020 at 04:54:35PM -0700, Steve Longerbeam wrote: > On 3/10/20 8:49 AM, Laurent Pinchart wrote: > > Hi Steve and Rui, > > > > I've spent more time on the i.MX7 support in the i.MX media staging > > driver today, and I've reached a point where I'm not comfortable moving > > forward without your ack. > > > > I found format handling to be very broken, the driver enumerates formats > > that are not supported by the device, and doesn't properly handle the > > supported formats. While trying to fix that, I found out that the common > > i.MX6 and i.MX7 helpers (imx-media-capture.c and imx-media-utils.c) get > > in the way, as i.MX6 and i.MX7 format support are very entangled. I > > would like to split the two in order to clean up the i.MX7 code, which > > would also give an opportunity to later clean the i.MX6 code if desired. > > > > Before moving in that time-consuming direction, I want to make sure this > > will be accepted, as I don't want to spend days of work for nothing. If > > you want to discuss this in real time, I'm available in the #v4l channel > > on Freenode (nickname pinchartl). > > I'm on vacation returning March 16, maybe we can chat on irc when I > return. I'm in California (PDT). Sure. Enjoy your vacation :-) In the meantime, I've moved forward with development without duplicating the whole imx-media-capture.c file, and I believe I'm close to reaching a working result. Some parts were not pretty (it's a staging driver after all), and if you agree with my approach, I think the end result will be much cleaner. Let's talk about it when you come back. -- Regards, Laurent Pinchart
