Re: [PATCH v2 10/10] media: imx: imx7-media-csi: Support clamping Y10 and Y12 to Y8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,
Thanks for this, I think this is the only one I did not acked.

On Tue, Mar 10, 2020 at 06:06:33PM +0200, Laurent Pinchart wrote:
> 10-bit and 12-bit greyscale input data to the CSI can be written as
> 8-bit data to memory. Support this.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Reviewed-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>

------
Cheers,
     Rui
> ---
>  drivers/staging/media/imx/imx7-media-csi.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> index e85202255168..3225082ce58d 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
> @@ -804,6 +804,14 @@ static int imx7_csi_configure(struct imx7_csi *csi)
>  	case V4L2_PIX_FMT_YUYV:
>  		cr18 |= BIT_MIPI_DATA_FORMAT_YUV422_8B;
>  		break;
> +	case V4L2_PIX_FMT_GREY:
> +		if (in_code == MEDIA_BUS_FMT_Y8_1X8)
> +			cr18 |= BIT_MIPI_DATA_FORMAT_RAW8;
> +		else if (in_code == MEDIA_BUS_FMT_Y10_1X10)
> +			cr18 |= BIT_MIPI_DATA_FORMAT_RAW10;
> +		else
> +			cr18 |= BIT_MIPI_DATA_FORMAT_RAW12;
> +		break;
>  	case V4L2_PIX_FMT_Y10:
>  		cr18 |= BIT_MIPI_DATA_FORMAT_RAW10;
>  		cr1 |= BIT_PIXEL_BIT;
> -- 
> Regards,
> 
> Laurent Pinchart
> 



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux