Re: [PATCH v4 0/3] v4l2-dev/ioctl: Add V4L2_CAP_IO_MC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/6/20 5:39 PM, Niklas Söderlund wrote:
> Hi,
> 
> This series aims to reduce the amount of boiler plate code in video
> device drivers who's inputs and/or outputs are controlled by the Media
> Controller instead of the V4L2 API.
> 
> Patch 1/3 adds a new video device capability flag V4L2_CAP_IO_MC which
> if set provides helper implementations for the enum inputs and outputs
> ioctrls freeing the video device driver from the need to implement them.
> 
> Patch 2/3 and 3/3 converts the R-Car VIN and Intel IPU3 drivers to use 
> the new default handlers and capability flag and delete the now  
> redundant boiler plate code. I'm sure more video device drivers
> can make use of this new flag but as I can only test on these two
> platforms I have limited my changes to those.

Can you add a patch that sets this for vimc as well? That's easy to test,
and helps adding compliance tests for this to v4l2-compliance.

Regards,

	Hans

> 
> Niklas Söderlund (3):
>   v4l2-dev/ioctl: Add V4L2_CAP_IO_MC
>   rcar-vin: Make use of V4L2_CAP_IO_MC
>   staging/intel-ipu3: Make use of V4L2_CAP_IO_MC
> 
>  .../media/uapi/v4l/vidioc-querycap.rst        |  6 ++
>  .../media/videodev2.h.rst.exceptions          |  1 +
>  drivers/media/platform/rcar-vin/rcar-v4l2.c   | 17 +-----
>  drivers/media/v4l2-core/v4l2-dev.c            | 25 ++++++--
>  drivers/media/v4l2-core/v4l2-ioctl.c          | 57 ++++++++++++++++--
>  drivers/staging/media/ipu3/ipu3-v4l2.c        | 60 +------------------
>  include/uapi/linux/videodev2.h                |  2 +
>  7 files changed, 84 insertions(+), 84 deletions(-)
> 




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux