On (20/02/19 09:53), Hans Verkuil wrote: [..] > This is starting to look pretty good. I think you can drop the RFC > for the next time you post this. OK! > One thing I would like to see as well is test code in v4l2-compliance, > specifically for testing the various flags and capabilities. I.e., > if V4L2_BUF_CAP_SUPPORTS_CACHE_HINTS, then it should test that it can > set the cache flags and the NON_CONSISTENT flag. If it is not set, > then those flags should be cleared when attempting to set them. > > Also code in v4l2-ctl and common/v4l2-info.cpp to support the new > flags, both reporting them, but also setting them. I do have two trivial patches - "sync videobuf kernel header" and "add new capability to common/v4l2-info.cpp". But v4l2-ctl and v4l2-compliance will require much more time, I think. So I, hopefully, will do it sometime later. -ss
