Hi Laurent
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > >
> > > The address of VSP2_VI6_HGT_LBx_H are
> > > VSP2_VI6_HGT_LB0_H : 0x3428
> > > VSP2_VI6_HGT_LB1_H : 0x3430
> > > VSP2_VI6_HGT_LB2_H : 0x3438
> > > VSP2_VI6_HGT_LB3_H : 0x3440
> > >
> > > Thus, VI6_HGT_LBn_H() macro should start from 0x3420 instead of 0x3430.
> > > This patch fixup it.
> >
> > I think this deserves a fixes tag:
> >
> > Fixes: 26e0ca22c3b8 ("[media] v4l: Renesas R-Car VSP1 driver")
>
> Given that this macro is not used, we could argue that it doesn't fix
> anything yet :-) I'd rather avoid having this backported to stable
> kernels as it's not useful to have it there, and thus not add a Fixes
> tag. Kieran, would that be OK with you ?
>
> > > Reported-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> >
> > Otherwise,
> >
> > Yes I can clearly see that this offset is marked as H'3428 at page 32-39
> > within the Gen3 datasheet.
> >
> > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> and taken in my branch.
My understanding is that this patch is applied to your branch,
but, is it correct ?
I still can't find it at linus/master and/or linux-next/master
Thank you for your help !!
Best regards
---
Kuninori Morimoto
