Re: [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg! Thanks for chiming in.


As you are a driver, you should never need to call any pr_* calls,
instead use dev_*().  For this, you can use dev_dbg(), but really, why
is that even needed except for your debugging bringup.  And for that,
you can use ftrace, right?  So no need for any printing of anything
here.
Again, dev_err() would be proper, but there's no need for any error
message here.

Let's take these out in v2 then.


Don't you need to register the tuner ops with something in this
function?
Don't you need to unregister the tuner ops in here?

It is my understanding that bridge drivers are the ones responsible for this. For instance, I don't see this with either xc4000.c, xc5000.c or mt2060.c. I could be wrong, though. Maybe Mauro could clarify this?

What I did miss in this patch was an attach function. Let's also add this in v2.


Thanks again,

- Daniel.




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux