Hi Mauro, On Thu, Jan 02, 2020 at 01:55:07PM +0000, Jenkins wrote: > From: builder@xxxxxxxxxxx > > Pull request: https://patchwork.linuxtv.org/patch/60967/ > Build log: https://builder.linuxtv.org/job/patchwork/31904/ > Build time: 00:04:57 > Link: https://lore.kernel.org/linux-media/20200102134658.GH5050@xxxxxxxxxxxxxxxxxxxxxxxxxx > > gpg: Signature made Thu 02 Jan 2020 01:42:43 PM UTC > gpg: using DSA key F0D0377A0D4F25A79238EFE56D40361B6E28C193 > gpg: issuer "sakari.ailus@xxxxxxxxxxxxxxx" > gpg: Good signature from "Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>" [full] > > Summary: 1 patches and/or PDF generation with issues, being 0 at build time > > Error/warnings: > > > Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-smiapp-Avoid-maintaining-power-state-information.patch: > $ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-smiapp-Avoid-maintaining-power-state-information.patch > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:114: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:120: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:132: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:139: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:146: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:152: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:158: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:164: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:170: CHECK: Lines should not end with a '(' > patches/0003-smiapp-Avoid-maintaining-power-state-information.patch:268: WARNING: Avoid multiple line dereference - prefer 'sensor->pixel_array->ctrl_handler' Regarding this --- parentheses beginning lines are abundantly used by the driver elsewhere (where they were originally moved from). If you prefer, I can send another patch reworking the code to remove parentheses beginning lines. It likely causes a number of cases where lines end up being longer than 80 chars though. -- Sakari Ailus
