Hi Shawn,
On Mon, Dec 30, 2019 at 06:51:57PM +0800, Shawnx Tu wrote:
> From: Shawn Tu <shawnx.tu@xxxxxxxxx>
>
> Add V4L2 controls: horizontal/vertical flip
>
> Signed-off-by: Shawn Tu <shawnx.tu@xxxxxxxxx>
> ---
> drivers/media/i2c/ov5675.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/drivers/media/i2c/ov5675.c b/drivers/media/i2c/ov5675.c
> index 1ae2523..9d948b4 100644
> --- a/drivers/media/i2c/ov5675.c
> +++ b/drivers/media/i2c/ov5675.c
> @@ -63,6 +63,11 @@
> #define OV5675_TEST_PATTERN_ENABLE BIT(7)
> #define OV5675_TEST_PATTERN_BAR_SHIFT 2
>
> +/* Flip Mirror Controls from sensor */
> +#define OV5675_REG_FORMAT1 0x3820
> +#define OV5675_REG_FORMAT1_HFLIP BIT(3)
> +#define OV5675_REG_FORMAT1_VFLIP BIT(4)
As the rotation changes the mbus pixel code, it needs to be taken into
account in setting the mbus format as well as mbus pixel code enumeration.
Could you include that in v3?
Thanks.
> +
> #define to_ov5675(_sd) container_of(_sd, struct ov5675, sd)
>
> enum {
> @@ -604,6 +609,36 @@ static int ov5675_test_pattern(struct ov5675 *ov5675, u32 pattern)
> OV5675_REG_VALUE_08BIT, pattern);
> }
>
> +static int ov5675_set_ctrl_hflip(struct ov5675 *ov5675, u32 ctrl_val)
> +{
> + int ret;
> + u32 val;
> +
> + ret = ov5675_read_reg(ov5675, OV5675_REG_FORMAT1,
> + OV5675_REG_VALUE_08BIT, &val);
> + if (ret)
> + return ret;
> +
> + return ov5675_write_reg(ov5675, OV5675_REG_FORMAT1,
> + OV5675_REG_VALUE_08BIT,
> + ctrl_val ? val & ~OV5675_REG_FORMAT1_HFLIP : val);
> +}
> +
> +static int ov5675_set_ctrl_vflip(struct ov5675 *ov5675, u8 ctrl_val)
> +{
> + int ret;
> + u32 val;
> +
> + ret = ov5675_read_reg(ov5675, OV5675_REG_FORMAT1,
> + OV5675_REG_VALUE_08BIT, &val);
> + if (ret)
> + return ret;
> +
> + return ov5675_write_reg(ov5675, OV5675_REG_FORMAT1,
> + OV5675_REG_VALUE_08BIT,
> + ctrl_val ? val | OV5675_REG_FORMAT1_VFLIP : val);
> +}
> +
> static int ov5675_set_ctrl(struct v4l2_ctrl *ctrl)
> {
> struct ov5675 *ov5675 = container_of(ctrl->handler,
> @@ -654,6 +689,14 @@ static int ov5675_set_ctrl(struct v4l2_ctrl *ctrl)
> ret = ov5675_test_pattern(ov5675, ctrl->val);
> break;
>
> + case V4L2_CID_HFLIP:
> + ov5675_set_ctrl_hflip(ov5675, ctrl->val);
> + break;
> +
> + case V4L2_CID_VFLIP:
> + ov5675_set_ctrl_vflip(ov5675, ctrl->val);
> + break;
> +
> default:
> ret = -EINVAL;
> break;
> @@ -722,6 +765,11 @@ static int ov5675_init_controls(struct ov5675 *ov5675)
> V4L2_CID_TEST_PATTERN,
> ARRAY_SIZE(ov5675_test_pattern_menu) - 1,
> 0, 0, ov5675_test_pattern_menu);
> + v4l2_ctrl_new_std(ctrl_hdlr, &ov5675_ctrl_ops,
> + V4L2_CID_HFLIP, 0, 1, 1, 0);
> + v4l2_ctrl_new_std(ctrl_hdlr, &ov5675_ctrl_ops,
> + V4L2_CID_VFLIP, 0, 1, 1, 0);
> +
> if (ctrl_hdlr->error)
> return ctrl_hdlr->error;
>
--
Kind regards,
Sakari Ailus
