Hello Laurent,
Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>:
> I'm sorry for the late reply, this patch fell through the cracks :-S
It's OK, thanks for getting back to it!
> > + /* Some devices report bpp that doesn't match the format. */
> > + if (dev->quirks & UVC_QUIRK_FORCE_BPP) {
>
> Both info and div can be declared here.
Right; however I was just following what seemed to be the existing
practice of declaring all variables at the start of a function (which
I'm not fond of myself; e.g. fmtdesc is only used in a single switch
branch). Now after looking at the code more, there are precedents for
declaring closer to point of use in e.g. uvc_parse_control and
elsewhere, so this is probably OK.
> The patch otherwise looks good
> to me, so I'll make this modification when applying it, unless you would
> prefer resending it.
Sure, go ahead, and thanks!
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> I however had a closer look at how bpp is used, and I think it would
> make sense to actually drop usage of this field.
This is most probably possible (the only cases I could think of in
which it couldn't be calculated, it would have to be fractional or no
meaningful value could be assigned to it) but out of scope of this
patch.
Best regards,
--
Sergey Zakharchenko
Digital Loggers, Inc.
