On 2019/12/16 21:01, Andrew F. Davis wrote: > On 12/16/19 5:08 AM, zhong jiang wrote: >> Fix the following sparse warning. >> >> drivers/gpu/drm/ast/ast_main.c:391:22: warning: symbol 'ast_mode_config_mode_valid' was not declared. Should it be static? >> > > The patch looks valid, but this commit message does not seem to match.. Sorry for stupid mistake. Will repost it in v2. Thanks, zhong jiang > > Andrew > > >> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> >> --- >> drivers/dma-buf/dma-heap.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c >> index 4f04d10..da2090e 100644 >> --- a/drivers/dma-buf/dma-heap.c >> +++ b/drivers/dma-buf/dma-heap.c >> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data) >> return 0; >> } >> >> -unsigned int dma_heap_ioctl_cmds[] = { >> +static unsigned int dma_heap_ioctl_cmds[] = { >> DMA_HEAP_IOC_ALLOC, >> }; >> >> > . >