Re: [PATCH] media: saa7146: Avoid using BUG_ON as an assertion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



…
> +++ b/drivers/media/common/saa7146/saa7146_video.c
@@ -345,7 +345,8 @@ static int video_begin(struct saa7146_fh *fh)
…
-	BUG_ON(NULL == fmt);
+	if (NULL == fmt)
…

Would you like to express a null pointer check in a succinct way?

+	if (!fmt)


Will the tag “Fixes” become helpful for the change description?

Regards,
Markus




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux