… > +++ b/drivers/media/common/saa7146/saa7146_video.c @@ -345,7 +345,8 @@ static int video_begin(struct saa7146_fh *fh) … - BUG_ON(NULL == fmt); + if (NULL == fmt) … Would you like to express a null pointer check in a succinct way? + if (!fmt) Will the tag “Fixes” become helpful for the change description? Regards, Markus