Hi Boris, > On 13 Dec 2019, at 12:54, Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote: > > Now that the core provides generic reflist builders, we can use them > instead of implementing our own. > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > --- > Changes in v3: > * New patch > --- > drivers/staging/media/hantro/hantro_h264.c | 237 +-------------------- > 1 file changed, 8 insertions(+), 229 deletions(-) > > diff --git a/drivers/staging/media/hantro/hantro_h264.c b/drivers/staging/media/hantro/hantro_h264.c > index 568640eab3a6..d998272d20e6 100644 > --- a/drivers/staging/media/hantro/hantro_h264.c > +++ b/drivers/staging/media/hantro/hantro_h264.c > @@ -11,7 +11,7 @@ > */ > > #include <linux/types.h> > -#include <linux/sort.h> > +#include <media/v4l2-h264.h> With this patch, CONFIG_VIDEO_HANTRO needs to depend on CONFIG_V4L2_H264, without that it can encounter linking errors due to missing symbols for v4l2_h264_init_reflist_builder, etc. > #include <media/v4l2-mem2mem.h> > #include "hantro.h" > @@ -240,229 +240,6 @@ static void prepare_table(struct hantro_ctx *ctx) > reorder_scaling_list(ctx); > } > ..snip.. -- Regards, Hugh Cole-Baker
