On Sat, Dec 14, 2019 at 4:38 AM Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote: > > On Fri, 13 Dec 2019 17:23:32 +0200 > Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > > Hi Boris, > > > > Thank you for the patch. > > > > On Fri, Dec 13, 2019 at 01:54:12PM +0100, Boris Brezillon wrote: > > > Document the Rockchip RK3399 Video Decoder bindings. > > > > > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > > > --- > > > Changes in v3: > > > * Fix dtbs_check failures > > > --- > > > .../bindings/media/rockchip,vdec.yaml | 71 +++++++++++++++++++ > > > 1 file changed, 71 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > > new file mode 100644 > > > index 000000000000..7167c3d6a389 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > > @@ -0,0 +1,71 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/rockchip,vdec.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Rockchip Video Decoder (VDec) Device Tree Bindings > > > + > > > +maintainers: > > > + - Heiko Stuebner <heiko@xxxxxxxxx> > > > + > > > +description: |- > > > + The Rockchip rk3399 has a stateless Video Decoder that can decodes H.264, > > > + HEVC an VP9 streams. > > > + > > > +properties: > > > + compatible: > > > + const: rockchip,rk3399-vdec > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: The Video Decoder AXI interface clock > > > + - description: The Video Decoder AHB interface clock > > > + - description: The Video Decoded CABAC clock > > > + - description: The Video Decoder core clock > > > + > > > + clock-names: > > > + items: > > > + - const: aclk > > > > How about calling it "axi" ? None of the other clock names have "clk". > > > > > + - const: iface > > > > And "ahb" here, as the AXI interface clock is also an interface clock ? > > Sure, I can do that. Another possibility: "master" for the AXI clock, and "slave" for the AHB clock. The AXI interface is likely the DMA master, while the AHB interface is a slave interface for the control registers. This is mostly based on hints from the crypto block. ChenYu
