Hi Hans,
On Fri, Dec 13, 2019 at 08:59:22AM +0100, Hans Verkuil wrote:
> On 12/12/19 8:17 PM, Rui Miguel Silva wrote:
> > It was defined a notifier in the csi_state structure that is never
> > allocated. And besides that it's unregister in the remove, even
> > though it is a no-op, just remove both.
> >
> > Fixes: 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver
> > subdev for i.MX7") Reported-by: Hans Verkuil <hverkuil@xxxxxxxxx>
> > Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Suggested-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > Signed-off-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>
>
> Mismatch between this Signed-off-by and your email address. Is it
> OK if I use your linaro email in this Signed-off-by?
Yeah, no problem. go ahead. Thanks.
------
Cheers,
Rui
>
> Regards,
>
> Hans
>
> > --- drivers/staging/media/imx/imx7-mipi-csis.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c
> > b/drivers/staging/media/imx/imx7-mipi-csis.c index
> > 99166afca071..383abecb3bec 100644 ---
> > a/drivers/staging/media/imx/imx7-mipi-csis.c +++
> > b/drivers/staging/media/imx/imx7-mipi-csis.c @@ -251,8 +251,6 @@
> > struct csi_state {
> >
> > struct mipi_csis_event events[MIPI_CSIS_NUM_EVENTS];
> >
> > - struct v4l2_async_notifier subdev_notifier; - struct
> > csis_hw_reset hw_reset; struct regulator *mipi_phy_regulator; bool
> > sink_linked; @@ -1104,7 +1102,6 @@ static int
> > mipi_csis_remove(struct platform_device *pdev)
> >
> > mipi_csis_debugfs_exit(state);
> > v4l2_async_unregister_subdev(&state->mipi_sd); -
> > v4l2_async_notifier_unregister(&state->subdev_notifier);
> >
> > pm_runtime_disable(&pdev->dev);
> > mipi_csis_pm_suspend(&pdev->dev, true);
> >
>
