Guennadi Liakhovetski wrote: > On Wed, 17 Feb 2010, Mauro Carvalho Chehab wrote: > >> Document all four 10-bit Bayer formats, 10-bit monochrome and a missing >> 8-bit Bayer formats. >> >> [mchehab@xxxxxxxxxx: remove duplicated symbol for V4L2-PIX-FMT-SGRBG10] >> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> >> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> >> --- >> Documentation/DocBook/Makefile | 3 + >> Documentation/DocBook/v4l/pixfmt-srggb10.xml | 90 ++++++++++++++++++++++++++ >> Documentation/DocBook/v4l/pixfmt-srggb8.xml | 67 +++++++++++++++++++ >> Documentation/DocBook/v4l/pixfmt-y10.xml | 79 ++++++++++++++++++++++ >> Documentation/DocBook/v4l/pixfmt.xml | 8 +-- >> 5 files changed, 242 insertions(+), 5 deletions(-) >> create mode 100644 Documentation/DocBook/v4l/pixfmt-srggb10.xml >> create mode 100644 Documentation/DocBook/v4l/pixfmt-srggb8.xml >> create mode 100644 Documentation/DocBook/v4l/pixfmt-y10.xml >> >> diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile >> index 65deaba..1c796fc 100644 >> --- a/Documentation/DocBook/Makefile >> +++ b/Documentation/DocBook/Makefile >> @@ -309,6 +309,9 @@ V4L_SGMLS = \ >> v4l/pixfmt-yuv422p.xml \ >> v4l/pixfmt-yuyv.xml \ >> v4l/pixfmt-yvyu.xml \ >> + v4l/pixfmt-srggb10.xml \ >> + v4l/pixfmt-srggb8.xml \ >> + v4l/pixfmt-y10.xml \ > > Mauro, why didn't you put them next to similar formats, as in my original > patch? Guennadi, Your original patch were against the out-of-tree "media-specs/Makefile", present only at the -hg tree. The way my conversion scripts work is that they'll convert the patches into a patch that can be applied directly into -git. Among other things, all changes on files outside the kernel tree are simply discarded by them. Also, before patch 2/4, such addition won't be possible. So, what happened here is that, after importing from your hg tree, I noticed -git compilation breakage. So, I ported the autobuild bits for media-entities & co, manually added the missing pixfmt xml's and removed the duplicate symbol for one of the bayer standards. That's said, I don't really have any preference about the order where the files appear at the Makefile. I have no objection if you prefer to add them on any other random order. In a matter of fact, IMO, the better is to later write a patch that discards this static list of files, auto-generating it dynamically. So, if you really prefer a different order, please re-submit another version for this patch. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
