On Tue, 03 Dec 2019, Enric Balletbo i Serra wrote: > This header file now only includes the cros_ec_dev struct, however, is the > 'include/linux/platform_data/cros_ec_proto.h' who contains the definition of > all the Chrome OS EC related structs. There is no reason to have a > separate include for this struct so move to the place where other > structs are defined. That way, we can remove the include itself, but also > simplify the common pattern > > #include <linux/mfd/cros_ec.h> > #include <linux/platform_data/cros_ec_proto.h> > > for a single include > > #include <linux/platform_data/cros_ec_proto.h> > > The changes to remove the cros_ec.h include were generated with the > following shell script: > > git grep -l "<linux/mfd/cros_ec.h>" | xargs sed -i '/<linux\/mfd\/cros_ec.h>/d' > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > --- > > drivers/iio/accel/cros_ec_accel_legacy.c | 1 - > .../common/cros_ec_sensors/cros_ec_sensors.c | 1 - > .../cros_ec_sensors/cros_ec_sensors_core.c | 1 - > drivers/iio/light/cros_ec_light_prox.c | 1 - > drivers/iio/pressure/cros_ec_baro.c | 1 - > .../media/platform/cros-ec-cec/cros-ec-cec.c | 1 - > drivers/mfd/cros_ec_dev.c | 1 - Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > drivers/platform/chrome/cros_ec_chardev.c | 1 - > drivers/platform/chrome/cros_ec_debugfs.c | 1 - > drivers/platform/chrome/cros_ec_lightbar.c | 1 - > drivers/platform/chrome/cros_ec_sensorhub.c | 1 - > drivers/platform/chrome/cros_ec_sysfs.c | 1 - > drivers/platform/chrome/cros_ec_vbc.c | 1 - > drivers/platform/chrome/cros_usbpd_logger.c | 1 - > drivers/power/supply/cros_usbpd-charger.c | 1 - > drivers/rtc/rtc-cros-ec.c | 1 - > include/linux/mfd/cros_ec.h | 35 ------------------- > include/linux/platform_data/cros_ec_proto.h | 23 +++++++++++- > 18 files changed, 22 insertions(+), 52 deletions(-) > delete mode 100644 include/linux/mfd/cros_ec.h -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog