Re: [PATCH] udmabuf: Remove deleted map/unmap handlers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 26, 2019 at 03:25:16PM +0100, Maarten Lankhorst wrote:
> Commit 7f0de8d80816 ("dma-buf: Drop dma_buf_k(un)map") removed map/unmap
> handlers, but they still existed in udmabuf. Remove them there as well
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Fixes: 7f0de8d80816 ("dma-buf: Drop dma_buf_k(un)map")
> Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx
> Cc: linaro-mm-sig@xxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx

/me puts on brown paper bag

Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

> ---
>  drivers/dma-buf/udmabuf.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index 9635897458a0..9de539c1def4 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -93,26 +93,10 @@ static void release_udmabuf(struct dma_buf *buf)
>  	kfree(ubuf);
>  }
>  
> -static void *kmap_udmabuf(struct dma_buf *buf, unsigned long page_num)
> -{
> -	struct udmabuf *ubuf = buf->priv;
> -	struct page *page = ubuf->pages[page_num];
> -
> -	return kmap(page);
> -}
> -
> -static void kunmap_udmabuf(struct dma_buf *buf, unsigned long page_num,
> -			   void *vaddr)
> -{
> -	kunmap(vaddr);
> -}
> -
>  static const struct dma_buf_ops udmabuf_ops = {
>  	.map_dma_buf	  = map_udmabuf,
>  	.unmap_dma_buf	  = unmap_udmabuf,
>  	.release	  = release_udmabuf,
> -	.map		  = kmap_udmabuf,
> -	.unmap		  = kunmap_udmabuf,
>  	.mmap		  = mmap_udmabuf,
>  };
>  
> -- 
> 2.24.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux