Hello Jacob, Thanks for the insight. On Tue, 2019-11-19 at 18:16 +0800, Jacob Chen wrote: > Hi Helen , > > Helen Koike <helen.koike@xxxxxxxxxxxxx> 于2019年11月14日周四 下午6:59写道： > > > > > > On 11/14/19 6:21 AM, Hans Verkuil wrote: > > > On 11/14/19 6:12 AM, Helen Koike wrote: > > > > From: Jacob Chen <jacob2.chen@xxxxxxxxxxxxxx> > > > > > > > > This commit add document for rkisp1 meta buffer format > > > > > > > > Signed-off-by: Jacob Chen <jacob-chen@xxxxxxxxxxxxxx> > > > > [refactored for upstream] > > > > Signed-off-by: Helen Koike <helen.koike@xxxxxxxxxxxxx> > > > > > > checkpatch gives me: > > > > > > WARNING: Missing Signed-off-by: line by nominal patch author 'Jacob Chen <jacob2.chen@xxxxxxxxxxxxxx>' > > > > > > Looking at this series I see duplicate Signed-off-by entries for Jacob Chen and a total > > > of three different email addresses: > > > > > > jacob2.chen@xxxxxxxxxxxxxx > > > jacob-chen@xxxxxxxxxxxxxx > > > cc@xxxxxxxxxxxxxx > > > > And I see a name in the Maintainers file as Jacob Chen <jacob-chen@xxxxxxxxxx>. > > I was wondering if I could replace the email by jacob-chen@xxxxxxxxxx, or if I should > > keep the original ones. > > > > Helen > > > > "jacob2.chen@xxxxxxxxxxxxxx"/"jacob-chen@xxxxxxxxxxxxxx" is me and > "cc@xxxxxxxxxxxxxx" is another one. > ' jacob-chen@xxxxxxxxxxxxxx' is invalid now, so you could replace the > email by 'jacob-chen@xxxxxxxxxx'. > Authorship and SOB can't be changed freely, the original must be retained, because this gives proper credit to the company that sponsored the work. I.e. if your mail used to be jacob2.chen at rock-chips.com, then I think we can use that. And if cc at rock-chips.com is a different engineer, also named Jacob Chen, perhaps we can mention that somewhere to reduce the confusion. Thanks, Ezequiel
