Hi Chunfeng-san,
> From: Chunfeng Yun, Sent: Thursday, November 14, 2019 7:41 PM
>
> Now the USB gadget subsystem can use the USB debugfs root directory,
> so move it's directory from the root of the debugfs filesystem into
> the root of usb
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
Thank you for the patch! When I apply this patch on the Greg's usb.git /
usb-next branch, the following warning happens:
$ patch -p1 < ~/Downloads/v3-10-13-usb-gadget-udc-renesas_usb3-create-debugfs-directory-under-usb-root.patch
patching file drivers/usb/gadget/udc/renesas_usb3.c
Hunk #1 succeeded at 2536 (offset 1 line).
I'm not sure we should fix it strictly though, this patch seems good to me. So,
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
And, I tested this patch on my environment and confirmed that
the debug file moved from /sys/kernel/debug to /sys/kernel/debug/usb. So,
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
Best regards,
Yoshihiro Shimoda
> ---
> v3: no changes
>
> v2:
> 1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root
> ---
> drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
> index e098f16c01cb..4dde69e7f6b1 100644
> --- a/drivers/usb/gadget/udc/renesas_usb3.c
> +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> @@ -2535,7 +2535,7 @@ static const struct file_operations renesas_usb3_b_device_fops = {
> static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3,
> struct device *dev)
> {
> - usb3->dentry = debugfs_create_dir(dev_name(dev), NULL);
> + usb3->dentry = debugfs_create_dir(dev_name(dev), usb_debug_root);
>
> debugfs_create_file("b_device", 0644, usb3->dentry, usb3,
> &renesas_usb3_b_device_fops);
> --
> 2.23.0
