On Wed, Nov 06, 2019 at 02:58:39PM -0600, Benoit Parrot wrote:
> Sakari Ailus <sakari.ailus@xxxxxx> wrote on Wed [2019-Nov-06 10:57:09 +0200]:
> > Hi Benoit,
> >
> > On Mon, Nov 04, 2019 at 01:31:32PM -0600, Benoit Parrot wrote:
> >
> > ...
> >
> > > +static struct cal_data dra76x_cal_data = {
> >
> > const?
>
> Hmm, most likely.
>
> >
> > > + .csi2_phy_core = dra76x_cal_csi_phy,
> > > + .num_csi2_phy = ARRAY_SIZE(dra76x_cal_csi_phy),
> > > +
> >
> > This newline seems extra.
> >
> > > + .flags = 0,
> >
> > And flags will be zero in any case, as one more struct members are assigned
> > to.
>
> Is this guaranteed or compiler version dependent?
C standard.
--
Sakari Ailus
