Re: [PATCH 6/8] ti-vpe: fix smatch error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote on Sun [2019-Nov-03 12:23:36 +0100]:
> This patch fixes this error:
> 
> drivers/media/platform/ti-vpe/vpdma.c:767 dump_dtd() error: '%pad' expects argument of type 'dma_addr_t*', argument 2 has type 'uint*'
> 
> dtd->start_addr is a u32, so no need for %pad.
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
> Cc: Benoit Parrot <bparrot@xxxxxx>
> ---
>  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> index 817d287c8138..2e5148ae7a0f 100644
> --- a/drivers/media/platform/ti-vpe/vpdma.c
> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> @@ -764,7 +764,7 @@ static void dump_dtd(struct vpdma_dtd *dtd)
>  		pr_debug("word1: line_length = %d, xfer_height = %d\n",
>  			dtd_get_line_length(dtd), dtd_get_xfer_height(dtd));
>  
> -	pr_debug("word2: start_addr = %pad\n", &dtd->start_addr);
> +	pr_debug("word2: start_addr = %x\n", dtd->start_addr);

Reviewed-by: Benoit Parrot <bparrot@xxxxxx>

>  
>  	pr_debug("word3: pkt_type = %d, mode = %d, dir = %d, chan = %d, pri = %d, next_chan = %d\n",
>  		 dtd_get_pkt_type(dtd),
> -- 
> 2.23.0
> 



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux